New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpd: Updated to GStreamer 1.0 #2062
Conversation
@@ -1167,7 +1167,7 @@ def start_bpd(self, lib, host, port, password, volume, debug): | |||
server.run() | |||
except NoGstreamerError: | |||
global_log.error(u'Gstreamer Python bindings not found.') | |||
global_log.error(u'Install "python-gst0.10", "py27-gst-python", ' | |||
global_log.error(u'Install "python-gst-1.0" ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably recommend the generic pygobject package (i.e., python-gi
or python2-gobject
) instead of a special-purpose python-gstreamer library.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome; thank you! I've done a light code review with a few small suggestions. It also occurs to me that we'll need to update the docs for the plugin (and add a changelog entry). |
@sampsyo Thanks for the review, i applied the recommendations and updated the docs. Please have a look at he changes 😄 |
Yay! Thank you again for tackling this longstanding issue. 🚀 All merged up! |
Updated GStreamer from 0.10 to 1.0, as mentioned in #2057.