Revive Beatport plugin with support for OAuth API (#1989)

[jbaiter]

This restores the previously removed Beatport plugin, this time around with support for their API version 3, which requires OAuth authentication with all endpoints.

The process of obtaining the authentication token and secret is modeled after the way the discogs plugin handles this, i.e. the user is asked to visit a website, enter her credentials and then paste the displayed string into the terminal. The plugin then extracts the token/secret and stores it in a file in the configuration directory.

I have not yet tested the integration with beets, so I would welcome any curious testers to try it out.

[sampsyo]

Yay! Fantastic -- this looks great after a quick review.

For the documentation, shall we revive the old documentation file too and add notes about the new OAuth workflow?

And not that it's urgent, but some of the methods in BeatportClient could use docstrings.

[jbaiter]

For the documentation, shall we revive the old documentation file too and add notes about the new OAuth workflow?

Yes, that's the most sensible way to go, since the OAuth thing is the only thing that has changed since the removal. I just added the old documentation file with a new paragraph on the OAuth workflow.

And not that it's urgent, but some of the methods in BeatportClient could use docstrings.

Done! :-)

[sampsyo]

Wahoo! ✨ That was fast! And the new text in the docs looks great. I'm happy we get to have a Beatport plugin again! 🚀

[itsbrex]

I'm up to date with the latest master branch, but am still getting ** plugin beatport not found beets version 1.3.18 no plugins loaded and nothing happens (i.e. no beatport OAuth website or anything). Any ideas what I am doing wrong?

[sampsyo]

Hmm, that's odd -- maybe you need to uninstall and reinstall? Things seem to work fine here.

[jackwilsdon]

That's peculiar. What's the output from git rev-parse HEAD inside the beets directory?

[itsbrex]

@sampsyo I actually did just uninstall & re-install because I was getting that error initially, but got it again after a clean install.

@jackwilsdon 0b17666b55f498e5f5b74bb5021da7c93b577690

[itsbrex]

@sampsyo what does your config file look like as far as options go?

[sampsyo]

This is the whole config file:

plugins: beatport

[itsbrex]

@sampsyo @jackwilsdon scratch that - I figured it out. I re-installed to a different folder and forgot to update the plugin path in config.yaml - oops!

[itsbrex]

@sampsyo so since there's no args to pass with it then does it just fetch all available metadata that beatport has?

[sampsyo]

Yes.

[itsbrex]

I just ran it, go the string in the browser but then got this: Traceback (most recent call last): File "/Users/anodigital/.pyenv/versions/2.7.10/bin/beet", line 9, in <module> load_entry_point('beets==1.3.18', 'console_scripts', 'beet')() File "/Users/anodigital/.pyenv/versions/2.7.10/lib/python2.7/site-packages/beets/ui/__init__.py", line 1250, in main _raw_main(args) File "/Users/anodigital/.pyenv/versions/2.7.10/lib/python2.7/site-packages/beets/ui/__init__.py", line 1240, in _raw_main subcommand.func(lib, suboptions, subargs) File "/Users/anodigital/.pyenv/versions/2.7.10/lib/python2.7/site-packages/beets/ui/commands.py", line 967, in import_func import_files(lib, paths, query) File "/Users/anodigital/.pyenv/versions/2.7.10/lib/python2.7/site-packages/beets/ui/commands.py", line 944, in import_files session.run() File "/Users/anodigital/.pyenv/versions/2.7.10/lib/python2.7/site-packages/beets/importer.py", line 320, in run pl.run_parallel(QUEUE_SIZE) File "/Users/anodigital/.pyenv/versions/2.7.10/lib/python2.7/site-packages/beets/util/pipeline.py", line 301, in run out = self.coro.send(msg) File "/Users/anodigital/.pyenv/versions/2.7.10/lib/python2.7/site-packages/beets/util/pipeline.py", line 183, in coro func(*(args + (task,))) File "/Users/anodigital/.pyenv/versions/2.7.10/lib/python2.7/site-packages/beets/importer.py", line 1264, in lookup_candidates task.lookup_candidates() File "/Users/anodigital/.pyenv/versions/2.7.10/lib/python2.7/site-packages/beets/importer.py", line 591, in lookup_candidates autotag.tag_album(self.items, search_ids=self.search_ids) File "/Users/anodigital/.pyenv/versions/2.7.10/lib/python2.7/site-packages/beets/autotag/match.py", line 439, in tag_album search_album, va_likely) File "/Users/anodigital/.pyenv/versions/2.7.10/lib/python2.7/site-packages/beets/autotag/hooks.py", line 582, in album_candidates out.extend(plugins.candidates(items, artist, album, va_likely)) File "/Users/anodigital/.pyenv/versions/2.7.10/lib/python2.7/site-packages/beets/plugins.py", line 355, in candidates out.extend(plugin.candidates(items, artist, album, va_likely)) File "/Users/anodigital/github/beets/beetsplug/beatport.py", line 344, in candidates return self._get_releases(query) File "/Users/anodigital/github/beets/beetsplug/beatport.py", line 396, in _get_releases for x in self.client.search(query).results] AttributeError: 'BeatportPlugin' object has no attribute 'client'

[jackwilsdon]

Do you think you could open a new issue with all of the necessary information @BrianRoach?

[itsbrex]

@jackwilsdon will do.

[jbaiter]

This is a bad naming confusion on my part, I had the client stored under beatport_api but accessed it with client. I just pushed a fix (plus one for another unrelated bug) to my branch and will open a PR. Sorry!

[itsbrex]

@jbaiter ah, no worries. thanks!

[willgrnr]

I am so glad this has finally made a comeback - thanks @jbaiter