-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lyrics: Try searching for song title component preceding : to strip subtitles #2205
Comments
Thanks for the detailed documentation! Seems like a good idea to try searching for the pre-colon part of the title. |
To make this more complicated than I initially thought, I found a counter example that needs the information post colon. Credits T Judd - I Stoled This Record - Skoal: The Grundy County Spitting Incident Without the information after the: With the information after the colon: So I am thinking the fix might be something along the lines of I did find yet another case that is even more complicated, and I don't have any ideas on how to code it. Nightwish - Angels Fall First - Lappi (Lapland): I. Erämaajärvi Musicbrainz album page, tracks 9-12: https://musicbrainz.org/release/2756c819-b6d7-3052-9ff8-8c05e65eb5df Stripping the information after the colon would download the lyrics, but for all songs. I don't see a clean way to only download the lyrics for a single song. Maybe this last case should be it's own bug. |
Thanks! @Kraymer has a fix that works for the first case, at least, by trying the title both with and without a subtitle. |
Thank you. I hope I provided enough information to fix not finding lyrics in one case without breaking finding lyrics in another case. |
Problem
The lyrics plugin fails to find the lyrics for titles that have a "subtitle" for example:
The musicbrainz artist - album - title
Nightwish - Endless Forms Most Beautiful - The Greatest Show on Earth: Chapter I) Four Point Six / Chapter II) Life / Chapter III) The Toolmaker / Chapter IV) The Understanding / Chapter V) Sea-Worn Driftwood
musicbrainz page for this song: https://musicbrainz.org/recording/42854595-599c-438d-b3f5-0be264d41ccb
Corresponds to lyricwiki title:
Nightwish - Endless Forms Most Beautiful - The Greatest Show on Earth
Lyricwiki page: http://lyrics.wikia.com/wiki/Nightwish:The_Greatest_Show_On_Earth
Basically, everything after the ":" needs to be dropped before searching.
This also applies to Pink Floyd - Atom Heart Mother - Atom Heart Mother: a) Father’s Shout / b) Breast Milky / c) Mother Fore / d) Funky Dung / e) Mind Your Throats Please / f) Remergence
Running this command in verbose (
-vv
) mode:Led to this problem:
Here's a link to the music files that trigger the bug (if relevant):
Setup
The text was updated successfully, but these errors were encountered: