sanitize playlist names #2258
Merged
sanitize playlist names #2258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make e. g. - name: $albumartist/$year-$album.m3u' work when album data includes non fs-friendly characters
|
This is a good idea; thanks! Can you please look into the test failures? Perhaps some tests need to be updated to stay in sync. Then, would you mind adding a quick changelog entry? |
sampsyo
reviewed
Nov 11, 2016
| @@ -186,7 +187,7 @@ def update_playlists(self, lib): | |||
| # As we allow tags in the m3u names, we'll need to iterate through | |||
| # the items and generate the correct m3u file names. | |||
| for item in items: | |||
| m3u_name = item.evaluate_template(name, True) | |||
| m3u_name = item.evaluate_template(sanitized_name, True) | |||
There was a problem hiding this comment.
Hmm; are you sure you want to be sanitizing the template instead of the result of filling in the template?
|
Thank you! ✨ I've merged this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make e. g.
work when album data includes non fs-friendly characters