XHProf role requires an internet connection during provision

[Decipher]

The XHProf role currently requires an internet connection during provision as it tries to install both the PECL channel and package regardless of whether it is already installed (which it is in Beetbox).

As such, it means that anyone trying to provision offline with the defaults (having XHProf role being installed) will not be able to do so.

I have already submitted a PR to the role that will resolve the issue (geerlingguy/ansible-role-php-xhprof#2), but until that PR is accepted we should consider a short-term fix.

The options I can see are:

• Remove XHProf from the defaults
• Apply the PR as a patch to the role
• Use a fork of the role

[thom8]

My preference would be to remove xhprof from the defaults until the PR is merged upstream.

[Decipher]

Agreed.

However, currently the PR I made for XHProf needs work as it is failing tests; It appears there's a false negative where if no version is detected (eg, it needs to be installed) the test is failing rather than installing XHProf.

[Decipher]

Merged a temporary removal of XHProf from the base box (won't come into play until the next build).

Have also updated the PR (geerlingguy/ansible-role-php-xhprof#2) so that it should now pass the tests.

[oxyc]

I believe this should be fixed upstream as soon as Centos 6 starts behaving and this PR gets merged: geerlingguy/ansible-role-php-xhprof#12

[thom8]

Thanks @oxyc!

@Decipher looks like we can add this back into the defaults.