Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a platform-specific cache key that rotates each month #71

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Use a platform-specific cache key that rotates each month #71

merged 1 commit into from
Nov 20, 2023

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Nov 19, 2023 •
edited

Changes

  • Only incorporates the target output format in the the cache key for Linux
  • The month and year are also included so the cache is replaced each month

Notes

  • Need to ensure the data directory doesn't change

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 marked this pull request as ready for review November 20, 2023 00:56
freakboy3742
freakboy3742 approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@freakboy3742 freakboy3742 merged commit 062546e into beeware:main Nov 20, 2023
58 checks passed
@rmartin16 rmartin16 deleted the briefcase-cache-hash branch November 20, 2023 14:40
@rmartin16 rmartin16 mentioned this pull request Dec 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rmartin16 @freakboy3742