Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recommentation to use nodeenv to install node #752

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@shaib
Copy link
Contributor

commented May 26, 2018

This is my preferred way of having node.js in a Python project, so I'm suggesting it.

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct
@@ -52,8 +52,17 @@ Install Node.JS
^^^^^^^^^^^^^^^

Lastly, you'll need to install `Node.js`_. You need to have a recent version
of Node; we test using v6.9.1. Once you've installed node, you can use it to
install Batavia's JavaScript dependencies, and compile the Batavia library:
of Node; we test using v6.9.1. One civilized way to get an isolated Node.js

This comment has been minimized.

Copy link
@freakboy3742

freakboy3742 May 27, 2018

Member

"civilized" is a little pejorative; also, if we're going to make the recommendation, the docs should commit to it - "We suggest using nodeenv", rather than "one way is to...".

Should we also add the --node=6.9.1 flag to ensure the right version is available?

This comment has been minimized.

Copy link
@shaib

shaib May 27, 2018

Author Contributor

I have a hard time committing to this suggestion, because my experience with node.js is rather limited. I agree to a less opinionated phrasing, we can drop "civilized".

With respect to the node version -- adding a specific one sounds like a good idea, but I've been working with the default (latest, currently v10.2.1) and there don't seem to be issues. Should we perhaps update?

@rayrrr

This comment has been minimized.

Copy link

commented Jul 26, 2018

I just evaluated nodeenv and nodenv while getting set up to run Batavia locally and decided on the latter. Any strong reasons to choose the former instead? I'm happy so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.