Skip to content
This repository has been archived by the owner on Jul 6, 2020. It is now read-only.

Only check the changed lines #27

Open
Tadaboody opened this issue Oct 23, 2018 · 1 comment
Open

Only check the changed lines #27

Tadaboody opened this issue Oct 23, 2018 · 1 comment

Comments

@Tadaboody
Copy link

Sometimes, some changes sneak into master that don't pass the checks.

If afterwards there a pull request is made in a completely different section of the code - the same checks will fail! with no fault of the contributor.

A possible fix for this is to only run checks on the lines that are changed by the PR.

@freakboy3742
Copy link
Member

This should be what is currently being done - beefore filters it's responses to lines that match the range of the diff of the patch being examined.

Can you provide an example where this has happened?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants