Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the output path for the translation update step. #311

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

freakboy3742
Copy link
Member

#310 reworked the Sphinx targets; however, I missed that the locale output directory was no longer correct as part of the changes (it was outputting into the project root directory, rather than the docs directory, due to the removal of the change_dir instruction).

This manifested as a build failure on the Update Translations job when the PR was merged.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

Copy link
Member

@rmartin16 rmartin16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, my bad; I didn't realize that command had an implicit output directory.

@freakboy3742
Copy link
Member Author

ah, my bad; I didn't realize that command had an implicit output directory.

Hey - I didn't pick it up in review either :-)

@freakboy3742 freakboy3742 merged commit 15d5530 into beeware:main Mar 8, 2024
9 checks passed
@freakboy3742 freakboy3742 deleted the translate-fix branch March 8, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants