Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not strip libraries from PyPI packages #29

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Nov 14, 2023

Changes

  • We've had issues with stripping libraries from PyPI before; this disables for Flatpak builds.
  • This is noticeably a problem for PySide2...although, PySide6 seemingly survives the stripping....either way, it seems a better policy to leave these libraries as-is

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 marked this pull request as ready for review November 14, 2023 16:24
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely makes sense to me.

However, we should probably add a release note to Briefcase to describe this. It's enough of a change that it would conceivably be surprising to someone.

Marking as approved; won't merge until we've got a changenote PR in place.

@freakboy3742 freakboy3742 merged commit 75d9d81 into beeware:main Nov 15, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants