Subprocess stream_output=False fixes

[rmartin16]

Changes

• When steam_output=False, disable dynamic console elements such as the Wait Bar.
• Remove condition of console control or output redirection for output streaming a command. These are irrelevant since output streaming will happen regardless unless stream_output=False...in which case console control will be released anyway now.

Related Issues

• Fixes The Use of stream_output=False is not Respected within a Controlled Console #1055

Notes

Looking at the tests and so forth (especially those in test_Subprocess__run__controlled_console.py), it seems clear that stream_output=False was not expected to actually disable streaming if the console was currently controlled. This was the wrong implementation.....but one that was probably based on the assumption that upstream code would not invoke commands that could not be streamed at the same time the console was controlled (e.g. running an unstreamable command in the Wait Bar). Earlier on, this was probably a reasonable assumption but we've made the framework much more flexible and accommodating since then.

Additionally, when #943 updated the default for stream_output from False to True, it probably should have also reconsidered downstream logic assuming stream_output would usually be False.

These changes should help streamline all this now.

PR Checklist:

• All new features have been tested
• All new features have been documented
• I have read the CONTRIBUTING.md file
• I will abide by the code of conduct

[freakboy3742]

I think this makes sense; it took me a bit to get comfortable with the change of logic around making _run_and_stream_output entirely controlled by stream_output, but I think the new setup works - it will just raise errors in different ways (but not in any usage that we're actually exercising).