-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle differences in UNC path parsing when generating extractPackages #1088
Conversation
32b3450
to
64eada6
Compare
64eada6
to
2e26e09
Compare
Tests are failing for me locally on Python 3.11.2. Just reran CI for windows-3.11 and 3.11.2 has not landed yet.
|
Good to know, but I don't think it's worth it here. We're not that sensitive to point updates that it's essential that every PR is tested against the very latest possible release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, and I can't argue with a passing test suite.
I agree; however, here, the test suite ran against Python 3.11.1. We need this test suite to run against Python 3.11.2 to test the changes. |
🤦 I missed the significance of what you were saying. I guess this means we'll see another CI failure in the near future... apologies for the confusion and premature merge. |
Closes #1087 by simply skipping over any
test_sources
items whose basename is empty. Since these are incomplete paths,briefcase create android
should already give an appropriate error message when it tries to copy them into the app, and this behavior hasn't changed. So I've marked the changenote asmisc
.PR Checklist: