Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS updates: output filters, requirements installation, docs #1439

Merged
merged 26 commits into from Oct 3, 2023

Conversation

freakboy3742
Copy link
Member

@freakboy3742 freakboy3742 commented Sep 5, 2023

As part of fixing beeware/Python-Apple-support#176, it has been necessary to switch to using .dylib extensions for binary extension modules on iOS. As a result, the Briefcase log filter no longer sees those output lines.

This PR:

  • Modifies the log filter to include .dylib extensions on iOS.
  • Modifies the dependency installation process on iOS to do 2 passes, one for device, and one for simulator.
  • Updates the Android publication docs to reflect recent changes
  • Adds iOS publication docs
  • Updates the FAQ, iOS and Android docs to provide details about binary wheels on the platform pages.

Testing these changes requires:

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@freakboy3742 freakboy3742 marked this pull request as ready for review September 27, 2023 01:57
@mhsmith mhsmith changed the title Modify iOS output filters to allow for .dylib extensions. iOS updates: output filters, requirements installation, docs Sep 28, 2023
@mhsmith
Copy link
Member

mhsmith commented Sep 28, 2023

CI is currently blocked by a merge failure, but previously it was failing because it needed the template update. Didn't we come up with some way to mark a Briefcase PR and a template PR as being linked so CI would test them together?

rmartin16 and others added 15 commits September 29, 2023 06:20
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.0.0 to 4.1.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v4.0.0...v4.1.0)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [setuptools-scm[toml]](https://github.com/pypa/setuptools_scm) from 7.1.0 to 8.0.3.
- [Release notes](https://github.com/pypa/setuptools_scm/releases)
- [Changelog](https://github.com/pypa/setuptools_scm/blob/main/CHANGELOG.md)
- [Commits](pypa/setuptools_scm@v7.1.0...v8.0.3)

---
updated-dependencies:
- dependency-name: setuptools-scm[toml]
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@freakboy3742
Copy link
Member Author

CI is currently blocked by a merge failure, but previously it was failing because it needed the template update. Didn't we come up with some way to mark a Briefcase PR and a template PR as being linked so CI would test them together?

It's difficult to do this for Briefcase CI tests because there are multiple templates - the base briefcase template, then one for each platform. However, the reverse arrangement does exist for templates, which is what the Xcode template has defined. The theory is that we can run the template against a branch of Briefcase, confirm that the template works with the current state of a specific Briefcase PR, merge the template PR on that basis, then re-run CI on briefcase against the now "dev" template as a final re-confirmation.

@freakboy3742 freakboy3742 merged commit 490f25a into beeware:main Oct 3, 2023
36 checks passed
@freakboy3742 freakboy3742 deleted the ios-dylib-binaries branch October 3, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants