Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support downloading Android emulator system image on Linux aarch64 #1519

Merged
merged 1 commit into from Nov 1, 2023

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Nov 1, 2023

Changes

  • Adds support to create an AVD on Linux for aarch64

Notes

  • This was the final major issue I had from my experimentation in Add support for Raspberry Pi #449
    • There's still the need to add android.aapt2FromMavenOverride to the gradle.properties file....but that's manageable as a manual thing....especially since you've still gotta get a working Android SDK first
  • The changenote is misc so as not to give the impression that Android on Linux for aarch64 works without quite a bit of prerequisite work

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 force-pushed the android-emulator-aarch64 branch 2 times, most recently from a4dc56b to 4d6425c Compare November 1, 2023 17:07
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a fairly straightforward change; I'll have to take your word that it works.

To clarify what's happened here - is this a case of something changing on the Java/Android side, or was this just an easy-win configuration change that we missed when we added the architecture checks?

@freakboy3742 freakboy3742 merged commit 8e41297 into beeware:main Nov 1, 2023
35 checks passed
@rmartin16 rmartin16 deleted the android-emulator-aarch64 branch November 1, 2023 21:57
@rmartin16
Copy link
Member Author

To clarify what's happened here - is this a case of something changing on the Java/Android side, or was this just an easy-win configuration change that we missed when we added the architecture checks?

More of an easy-change config win that I didn't include in #1360. At the time, I was still coming to grips with more of my current understanding of the Android SDK.....so, I left out this change at the time. Today, though, I added building an Android app to my "proto-buildbot" experiment and realized I felt more comfortable about adding this support for Linux on aarch64 now.

rmartin16 pushed a commit to rmartin16/briefcase that referenced this pull request Nov 5, 2023
Support downloading Android emulator system image on Linux aarch64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants