Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building on Python 3.12 requires setuptools >=67 #1527

Merged
merged 1 commit into from Nov 6, 2023

Conversation

rmartin16
Copy link
Member

This is as much an FYI as anything, I suppose.

I was messing around with package building and noticed setuptools_scm >=8 recommends (err...requires...) setuptools >=64. Out of curiosity, I tried to build Briefcase with setuptools ==60 using Python 3.12 but it bombs out in setuptools on some import of nonexistent code. I bumped setuptools until the build would work and landed at >=67.

For any of our purposes, this doesn't really matter since the latest version of setuptools will always be used. However, if someone tried to package Briefcase themselves, the current setuptools version constraint isn't really truthful.

Furthermore, if you were following greg's recent chain about moving to pyproject.toml, he pointed out that pinning build requirements can create downstream problems. So, while Briefcase is unlikely to be a dependency for anything....it doesn't generally seem reliable to use pinning here 馃槙

At any rate...this'll make the setuptools build version constraint a little more truthful.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All makes sense.

@freakboy3742 freakboy3742 merged commit 544b3e2 into beeware:main Nov 6, 2023
35 checks passed
@rmartin16 rmartin16 deleted the build-reqs branch November 7, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants