Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Flatpak runtime versions for new projects #1545

Merged
merged 2 commits into from Jan 14, 2024

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Nov 19, 2023

Changes

  • Bump Flatpak runtime versions
    • org.freedesktop.Platform: 22.08 -> 23.08
    • org.kde.Platform: 6.4 -> 6.6
    • org.gnome.Platform: 44 -> 45

Notes

org.gnome.Platform==45, org.kde.Platform==6.6, and org.freedesktop.Platform==23.08 do not have libcrypt.so.1 and Flatpak builds are failing because Standalone Python is still looking for it.... I was under the impression that Standalone Python was dropping its dependency on this ancient library....but maybe I misunderstood something....

libcrypt.so was dropped for Python 3.10, 3.9, and 3.8 with indygreg/python-build-standalone@80cd87f and released in 20240107.

Dependencies

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16
Copy link
Member Author

rmartin16 commented Nov 20, 2023

I've narrowed this down to being a problem for Python 3.8, 3.9, and 3.10; when using Python 3.11 and 3.12, the dependency on libcrypt.so.1 is absent. This is true for both releases 20231002 and 20230826.

ldd ./build/flatpaktest/linux/flatpak/support/python/bin/python3.11
	linux-vdso.so.1 (0x00007ffeda74f000)
	/home/user/tmp/beeware/flatpaktest/./build/flatpaktest/linux/flatpak/support/python/bin/../lib/libpython3.11.so.1.0 (0x00007f6859c00000)
	libpthread.so.0 => /lib64/libpthread.so.0 (0x00007f685b42f000)
	libdl.so.2 => /lib64/libdl.so.2 (0x00007f685b42a000)
	libutil.so.1 => /lib64/libutil.so.1 (0x00007f685b425000)
	libm.so.6 => /lib64/libm.so.6 (0x00007f6859b1f000)
	librt.so.1 => /lib64/librt.so.1 (0x00007f685b41e000)
	libc.so.6 => /lib64/libc.so.6 (0x00007f685993d000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f685b44f000)
ldd ./build/flatpaktest/linux/flatpak/support/python/bin/python3.10
	linux-vdso.so.1 (0x00007ffe1c6ef000)
	/home/user/tmp/beeware/flatpaktest/./build/flatpaktest/linux/flatpak/support/python/bin/../lib/libpython3.10.so.1.0 (0x00007ffad6800000)
	libcrypt.so.1 => not found
	libpthread.so.0 => /lib64/libpthread.so.0 (0x00007ffad7e9a000)
	libdl.so.2 => /lib64/libdl.so.2 (0x00007ffad7e95000)
	libutil.so.1 => /lib64/libutil.so.1 (0x00007ffad7e90000)
	libm.so.6 => /lib64/libm.so.6 (0x00007ffad7dad000)
	librt.so.1 => /lib64/librt.so.1 (0x00007ffad7da8000)
	libc.so.6 => /lib64/libc.so.6 (0x00007ffad661e000)
	/lib64/ld-linux-x86-64.so.2 (0x00007ffad7eba000)
	libcrypt.so.1 => not found

The development in Standalone Python that claimed to remove this dependency didn't make any carve outs for older Python; so, I'm not sure if this in intentional or what yet.

@rmartin16
Copy link
Member Author

Feedback in indygreg/python-build-standalone#173 (comment) confirms that Python 3.8, 3.9, and 3.10 should not be linking libcrypt.so.1 like this. I created indygreg/python-build-standalone#197 to document this. Elsewhere indygreg commented they won't be able to make another release until Christmas or later (not that I consider that a committed timeline or anything).

As a note, org.kde.Platform==6.4 (the current version used in the template) is EOL; 6.5 doesn't have this issue....but I also can't find the EOL schedule for the KDE runtimes...

@rmartin16 rmartin16 marked this pull request as ready for review January 10, 2024 00:58
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've clarified the specific versions in the release note; but otherwise 👍

@freakboy3742 freakboy3742 merged commit a995b09 into beeware:main Jan 14, 2024
44 checks passed
@rmartin16 rmartin16 deleted the bump-flatpak-runtimes branch April 29, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants