Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify imports that are dependent on the version of Python #1557

Merged
merged 1 commit into from Nov 28, 2023
Merged

Clarify imports that are dependent on the version of Python #1557

merged 1 commit into from Nov 28, 2023

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Nov 28, 2023 •
edited

Changes

  • For imports that are dependent on the version of Python, make that explicit and use a syntax that pyupgrade can automatically handle for Python EOLs
  • Given that pyupgrade can change imports, run it before isort runs in pre-commit
  • Installing toml package is no longer necessary to run isort in pre-commit
  • Instead of assuming knowledge about codespell's usage of TOML (such as the fact it uses the tomli package), instruct pre-commit to install the toml extra for codespell

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 marked this pull request as ready for review November 28, 2023 18:04
freakboy3742
freakboy3742 approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@freakboy3742 freakboy3742 merged commit 0723ee5 into beeware:main Nov 28, 2023
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rmartin16 @freakboy3742