Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin all deps in tox.ini #1686

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

rmartin16
Copy link
Member

Changes

Notes

  • As it relates to towncrier, I confirmed the changes to docs/background/releases.rst were the same for this version as the previous.
  • Additionally, I noticed that the current use of towncrier in tox seemingly requires that Briefcase has been installed...otherwise, the version is indeterminable.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 marked this pull request as ready for review March 7, 2024 19:48
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The towncrier update makes me mildly nervous, because we only ever run towncrier when we're doing a release, so there's no real exercising of this until we actually cut a release. I'm not sure there's a better option, though - testing release notes is going to be near impossible, and tweaking a towncrier config for compatibility as part of a release isn't the end of the world.

@freakboy3742 freakboy3742 merged commit 5616e14 into beeware:main Mar 7, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants