Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fsdecode() calls for subprocess commands #1694

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Mar 13, 2024

Changes

  • Removes calls to os.fsdecode() for command arguments for subprocess calls
  • subprocess will call fsdecode() for subprocess command arguments for us
    • Windows: subprocess always calls list2cmdlist for Windows processes
    • POSIX: for posix_spawn path or the fork_exec path, everything has fsdecode called

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 force-pushed the subprocess-fsdecode branch 3 times, most recently from 8b4398e to be53ac2 Compare March 13, 2024 19:08
@rmartin16 rmartin16 marked this pull request as ready for review March 13, 2024 19:43
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all makes sense; the RTD build failure looks to be unrelated. I've pushed #1695 to correct this; once that lands we can rebase and get a clean board here. Approving on that basis; as soon as there's a clean CI run, I'm OK to merge.

@freakboy3742 freakboy3742 merged commit 65d425a into beeware:main Mar 14, 2024
51 checks passed
@rmartin16 rmartin16 deleted the subprocess-fsdecode branch March 14, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants