ISSUE-1472: Added xcrun debugging tips to error message for failed signing attempts #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethompsy
changed the title
freakboy3742
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a bit of guidance for failed signing attempts on MacOS to smooth the issue described in #1472. Considering that we would need to run
xcrun notarytool historyto first find thesubmission-idof the failed signing attempt before runningxcrun notarytool log <submission-id>to get the logs, all within the except of a try/except, it seems most sensible to just inform the user of how they could track down the error themselves.Refs #1472
PR Checklist: