Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on first run after iOS simulator update #1828

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ashleyplusplus
Copy link
Contributor

@ashleyplusplus ashleyplusplus commented May 21, 2024

Added logic to the JSON parser in subprocess.py to grab everything from the first { forward. This makes sure that it's only parsing- for lack of better phrasing- parseable stuff instead of just trying to parse the entire output, which contains "Install started, 1%... " on the first run after an iOS simulator update. Fixes #780.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@ashleyplusplus
Copy link
Contributor Author

I haven't installed my iOS simulator yet (new laptop), so I'm planning on testing by installing my simulator and running this.

@phildini
Copy link
Member

Hoisting up the test failures:

tests/integrations/subprocess/test_json_parser.py::test_json_parser_fail[This is a prologue in my JSON output :( \n\n{"key": "value"}1] FAILED [ 65%]```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on first run after iOS simulator is updated
2 participants