Avoid ResourceWarnings during tests for /dev/null handle #879
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #867,
pytest
will raise for all Python errors including those normally suppressed. This change is also causing the errors/warnings below to be printed sometimes when pytest is run.These changes ensure the file handle for
/dev/null/ that's opened for the logfile Rich Console is closed before
pytest` exits so this error is showed to developers and avoids subsequent confusion.In practice, these errors are innocuous. Furthermore, end-users cannot see these errors unless they run a debug version of Python or use the
-Werror
(or perhaps the-Wdefault
) flag.PR Checklist: