Skip to content

Commit

Permalink
Merge pull request #179 from dgelessus/changes_fixes
Browse files Browse the repository at this point in the history
Fix some minor formatting and wording issues in change fragments
  • Loading branch information
freakboy3742 committed May 16, 2020
2 parents 80058a6 + 161ebda commit fd3c1aa
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 6 deletions.
2 changes: 1 addition & 1 deletion changes/118.doc.rst
@@ -1 +1 @@
Added detailed :doc:`reference documentation </reference/index>` for all public APIs of :mod:`rubicon-objc`.
Added detailed :doc:`reference documentation </reference/index>` for all public APIs of :mod:`rubicon.objc`.
2 changes: 1 addition & 1 deletion changes/170.bugfix.rst
@@ -1 +1 @@
Correct the invocation of NSApplication.terminate() when the lifecycle is ended.
Corrected the invocation of ``NSApplication.terminate()`` when the :class:`~rubicon.objc.eventloop.CocoaLifecycle` is ended.
7 changes: 4 additions & 3 deletions changes/174.removal.rst
Expand Up @@ -16,9 +16,10 @@ features that were rarely used, or likely to be used by accident in an unsafe wa
* Disallowed passing :class:`~ctypes.c_void_p` objects as the ``receiver`` argument of
:func:`~rubicon.objc.runtime.send_message`. The ``receiver`` argument now has to be of type
:class:`~rubicon.objc.runtime.objc_id`, or one of its subclasses (such as :class:`~rubicon.objc.runtime.Class`),
or one of its high-level equivalents (such as :class:`~rubicon.objc.api.ObjCInstance`). This is the case for all
Objective-C objects returned by Rubicon's high-level and low-level APIs. If you need to send a message to an object
pointer stored as :class:`~ctypes.c_void_p`, :func:`~ctypes.cast` it to :class:`~rubicon.objc.runtime.objc_id` first.
or one of its high-level equivalents (such as :class:`~rubicon.objc.api.ObjCInstance`). All Objective-C objects
returned by Rubicon's high-level and low-level APIs have one of these types. If you need to send a message to an
object pointer stored as :class:`~ctypes.c_void_p`, :func:`~ctypes.cast` it to :class:`~rubicon.objc.runtime.objc_id`
first.
* Removed default values for :func:`~rubicon.objc.runtime.send_message`'s ``restype`` and ``argtypes`` keyword
arguments. Every :func:`~rubicon.objc.runtime.send_message` call now needs to have its return and argument types
set explicitly. This ensures that all arguments and the return value are converted correctly between (Objective-)C
Expand Down
2 changes: 1 addition & 1 deletion changes/177.feature.rst
@@ -1,4 +1,4 @@
Changed ``ObjCMethod``` to call methods using :func:`~rubicon.objc.runtime.send_message`
Changed ``ObjCMethod`` to call methods using :func:`~rubicon.objc.runtime.send_message`
instead of calling :class:`~rubicon.objc.runtime.IMP`\s directly. This is mainly an internal change and should not
affect most existing code, although it may improve compatibility with Objective-C code that makes heavy use of runtime
reflection and method manipulation (such as swizzling).
1 change: 1 addition & 0 deletions changes/179.misc.rst
@@ -0,0 +1 @@
Fixed some minor formatting and wording issues in a few change fragments.

0 comments on commit fd3c1aa

Please sign in to comment.