Merge pull request #2017 from freakboy3742/audit-tree

[widget Audit] toga.Tree

android/src/toga_android/widgets/table.py

@@ -1,5 +1,9 @@
+from warnings import warn
+
 from travertino.size import at_least
 
+import toga
+
 from ..libs.activity import MainActivity
 from ..libs.android import R__attr
 from ..libs.android.graphics import Rect, Typeface
@@ -162,13 +166,14 @@ def create_table_row(self, row_index):
         return table_row
 
     def get_data_value(self, row_index, col_index):
-        row_object = self.interface.data[row_index]
         value = getattr(
-            row_object,
+            self.interface.data[row_index],
             self.interface._accessors[col_index],
             None,
         )
-
+        if isinstance(value, toga.Widget):
+            warn("This backend does not support the use of widgets in cells")
+            value = None
         if isinstance(value, tuple):  # TODO: support icons
             value = value[1]
         if value is None:

android/tests_backend/widgets/table.py

@@ -3,6 +3,7 @@
 from android.widget import ScrollView, TableLayout, TextView
 
 from .base import SimpleProbe
+from .properties import toga_font
 
 HEADER = "HEADER"
 
@@ -11,6 +12,7 @@ class TableProbe(SimpleProbe):
     native_class = ScrollView
     supports_icons = False
     supports_keyboard_shortcuts = False
+    supports_widgets = False
 
     def __init__(self, widget):
         super().__init__(widget)
@@ -86,3 +88,8 @@ async def select_row(self, row, add=False):
 
     async def activate_row(self, row):
         self._row_view(row).performLongClick()
+
+    @property
+    def font(self):
+        tv = self._row_view(0).getChildAt(0)
+        return toga_font(tv.getTypeface(), tv.getTextSize(), tv.getResources())

changes/1767.feature.txt

@@ -0,0 +1,2 @@
+Headings are no longer mandatory for Tree widgets.
+If headings are not provided, the widget will not display its header bar.

changes/2011.removal.2.rst

@@ -1 +1 @@
-Tables now use an empty string for the default missing value on a Table.
+Tables now use an empty string for the default missing value, rather than warning about missing values.

changes/2017.feature.1.rst

@@ -0,0 +1 @@
+The Tree widget now has 100% test coverage and complete API documentation.

changes/2017.feature.2.rst

@@ -0,0 +1 @@
+Columns can now be added and removed from a Tree.

changes/2017.removal.1.rst

@@ -0,0 +1 @@
+The ``parent`` argument has been removed from the ``insert`` and ``append`` calls on ``TreeSource``. This improves consistency between the API for ``TreeSource`` and the API for ``list``. To insert or append a row in to a descendent of a TreeSource root, use ``insert`` and ``append`` on the parent node itself - i.e., ``source.insert(parent, index, ...)`` becomes ``parent.insert(index, ...)``, and ``source.insert(None, index, ...)`` becomes ``source.insert(index, ...)``.

changes/2017.removal.2.rst

@@ -0,0 +1 @@
+Trees now use an empty string for the default missing value, rather than warning about missing values.

changes/2017.removal.3.rst

@@ -0,0 +1 @@
+``Table.on_double_click`` has been renamed ``Table.on_activate``.