-
-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Android test discovery workarounds #1747
Conversation
8be658b
to
db867e4
Compare
CI will have to be rerun once beeware/briefcase-android-gradle-template#60 is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I initially had some difficulty getting this working on Py3.10 (log file); but after stepping away and coming back to it, I can't reproduce that failure. I'm guessing I had something stale in my environment, but I can't work out what.
Otherwise - seems to work well.
I've merged up the macOS-probe changes, which also means we now have a coverage report on Android. There is a workaround required because of nedbat/coveragepy#1542. |
OK, I've reproduced this now: see chaquo/chaquopy#777. |
I've fixed an issue with the coverage workaround which was crashing the test thread on desktop platforms, and added a top-level exception handler so the app will exit in such cases rather than hanging forever. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those changes all make sense to me; 👍
They're no longer needed now that extractPackages is in the Android template.
Requires beeware/briefcase-android-gradle-template#60: DO NOT MERGE this PR before that one.
I've also added an
extractPackages
line fortoga_android
, which should allow #1707 to remove the code that disables coverage on Android.PR Checklist: