Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move GTK font measuring to Canvas widget #1902

Merged
merged 2 commits into from Apr 26, 2023
Merged

Move GTK font measuring to Canvas widget #1902

merged 2 commits into from Apr 26, 2023

Conversation

studioph
Copy link
Contributor

@studioph studioph commented Apr 25, 2023 •
edited

Changes

  • Moves the logic for measuring font size on GTK from the Font class to the Canvas widget to align with Winforms.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

freakboy3742
freakboy3742 approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@studioph studioph mentioned this pull request Apr 25, 2023
Merged
11 tasks
@freakboy3742 freakboy3742 merged commit 9cb2257 into beeware:main Apr 26, 2023
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@studioph @freakboy3742