New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine Linux dependencies for developing and using Toga #2021
Conversation
4c8880d
to
387b599
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor issues to clarify.
.github/workflows/ci.yml
Outdated
pre-command: "sudo apt-get update -y && sudo apt-get install -y python3-gi python3-gi-cairo gir1.2-gtk-3.0 python3-dev libgirepository1.0-dev libcairo2-dev pkg-config libfuse2" | ||
pre-command: | | ||
sudo apt update -y | ||
sudo apt install -y libfuse2 pkg-config python3-dev libgirepository1.0-dev libcairo2-dev gir1.2-gtk-3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure libfuse2 isn't needed any more - it was only required because we were using AppImages.
docs/how-to/contribute-code.rst
Outdated
|
||
Fedora | ||
|
||
.. code-block:: console | ||
|
||
(venv) $ sudo dnf install pkg-config python3-devel gobject-introspection-devel cairo-devel cairo-gobject-devel pango-devel webkitgtk3 | ||
(venv) $ sudo dnf install pkg-config python3-devel gobject-introspection-devel cairo-gobject-devel webkitgtk4 libcanberra-gtk3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is webkitgtk4
correct, or a typo? I just noticed it here, but I can see it's on the main beeware tutorial as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is technically correct...but there is apparently a better option.
The webkitgtk4
package was renamed and redirects to webkit2gtk3
.
I'll update these references.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was curious where I got this from....it was apparently pre-existing in the tutorial before I climbed into this rabbit hole :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh, i see....beeware/beeware#50 used webkitgtk4
since it was more widely available after the rename to webkit2gtk3
. I think these concerns should be mitigated now given most of the unsupported distro versions are EOL.
docs/tutorial/tutorial-0.rst
Outdated
|
||
Fedora | ||
|
||
.. code-block:: console | ||
|
||
(venv) $ sudo dnf install pkg-config python3-devel gobject-introspection-devel cairo-devel cairo-gobject-devel pango-devel webkitgtk3 | ||
(venv) $ sudo dnf install pkg-config python3-devel gobject-introspection-devel cairo-gobject-devel webkitgtk4 libcanberra-gtk3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same webkitgtk4
comment here.
gtk/README.rst
Outdated
|
||
* **Ubuntu 16.04 / Debian 8** ``apt-get install python3-gi gir1.2-webkit2-4.0`` | ||
or ``apt-get install python3-gi gir1.2-webkit-3.0`` | ||
* **Fedora** ``sudo dnf install python3-gobject webkitgtk4`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And again here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Changes
PyGObject
andcairo
from Debian repospython3-gi
,python3-gi-cairo
, etcPyGObject
is installed from PyPI, it brings along all the Python stuff it needslibpango1.0-dev
since these headers are not needed for anythinglibpango
will be installed as a dependency oflibgtk-3-0
PR Checklist: