Enable test_keys on WinForms

[mhsmith]

Having run into some problems in this area last week, I now understand what this test is for.

• Closes toga.Key is not documented #2199

[mhsmith]

Consistently using lower case makes the conversion code simpler.

[mhsmith]

Although GTK and Cocoa treat caps lock as a modifier, WinForms does not. And it wouldn't make sense anyway in the context of command shortcuts -- nobody will ask for a shortcut of "Caps Lock + X".

[freakboy3742]

There's a subset of Emacs stalwarts who map CapsLock to CTRL to match old IBM Model F keyboards who might take umbrage with this claim :-) However, I agree that in modern practice, CAPSLOCK is highly unlikely to be used as a modifier

However, we're technically removing functionality, so we should add a release note about this.

[freakboy3742]

Looks good - it's a little surprising that there's no modifier enum for the Windows key, but I can't seen any reference to it in the Keys enum (there's representations of LWin and RWin, but no generic "Windows" key).

I've added the removal changenote that I flagged, and also added docs. If you're happy with those docs, feel free to merge.

[freakboy3742]

There's a subset of Emacs stalwarts who map CapsLock to CTRL to match old IBM Model F keyboards who might take umbrage with this claim :-) However, I agree that in modern practice, CAPSLOCK is highly unlikely to be used as a modifier

However, we're technically removing functionality, so we should add a release note about this.

[mhsmith]

it's a little surprising that there's no modifier enum for the Windows key, but I can't seen any reference to it in the Keys enum (there's representations of LWin and RWin, but no generic "Windows" key).

I think that's because Windows key combinations are supposed to be handled by the system, rather than individual apps.