Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: moved app command creation to method _create_app_commands() #2215

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Android: moved app command creation to method _create_app_commands() #2215

merged 2 commits into from
Nov 8, 2023

Conversation

t-arn
Copy link
Contributor

@t-arn t-arn commented Nov 8, 2023

This PR moves the Android app command creation into the method _create_app_commands() like it is for the other platforms

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@t-arn
Copy link
Contributor Author

t-arn commented Nov 8, 2023

@freakboy3742 Please review this PR

freakboy3742
freakboy3742 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@freakboy3742 freakboy3742 merged commit 3a94cd7 into beeware:main Nov 8, 2023
35 checks passed
@t-arn t-arn deleted the android_create_app_commands branch November 8, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@t-arn @freakboy3742