Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add toga.App.app to docs #2413

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Add toga.App.app to docs #2413

merged 1 commit into from
Feb 20, 2024

Conversation

rmartin16
Copy link
Member

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 force-pushed the doc-app branch 2 times, most recently from dbd9d52 to 3e34b0c Compare February 20, 2024 18:16
@rmartin16
Copy link
Member Author

Unfortunately, this shows toga.App.app having a value of None....I've addressed in #2252 by removing this initialization....but I don't want to do that here.

@rmartin16 rmartin16 marked this pull request as ready for review February 20, 2024 20:12
@freakboy3742 freakboy3742 added the documentation An improvement required in the project's documentation. label Feb 20, 2024
freakboy3742
freakboy3742 approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@freakboy3742 freakboy3742 merged commit 79527e1 into beeware:main Feb 20, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
documentation An improvement required in the project's documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rmartin16 @freakboy3742