Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WebKit2 dependencies #2545

Merged
merged 9 commits into from
May 1, 2024
Merged

Conversation

freakboy3742
Copy link
Member

Updates the unix pre-requisites to accomodate the WebKit2 package changes, primarily for the benefit of Ubuntu 24.04.

WebKit2 has been removed from the general Linux requirements list, in favor of a base set of packages plus an explicit list of system requirements on widgets that require it. The error message raised when those system requirements can't be found now explicitly references the system requirements in the docs (although the anchor on the link won't be valid until a stable release is cut).

Fixes #2544.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

Copy link
Member

@rmartin16 rmartin16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good. I added a few notes/corrections in line.

docs/reference/api/widgets/mapview.rst Outdated Show resolved Hide resolved
docs/reference/api/widgets/webview.rst Outdated Show resolved Hide resolved
docs/reference/api/widgets/webview.rst Outdated Show resolved Hide resolved
docs/reference/api/widgets/mapview.rst Outdated Show resolved Hide resolved
docs/reference/platforms/unix-prerequisites.rst Outdated Show resolved Hide resolved
Copy link
Member

@rmartin16 rmartin16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good deal. I saw some additional opportunities to add details for OpenSUSE and align the specific list of reqs across the distros...but that seemed out of scope here. 👍🏼

@freakboy3742 freakboy3742 merged commit 8eace47 into beeware:main May 1, 2024
35 checks passed
@freakboy3742 freakboy3742 deleted the unix-deps branch May 1, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Linux system requirements for WebKit2
2 participants