Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make releases resilient to failures. #2555

Merged
merged 2 commits into from
May 7, 2024

Conversation

freakboy3742
Copy link
Member

The release of v0.4.3 required 2 passes, because the use of a pre-release freezegun version wasn't picked up as a problem until the toga-core package was pushed to PyPI. However, by this point, toga-android had been successfully published.

As a result of this, any attempt to re-publish toga-android will fail, because the wheel already exists; but there's no way to make any other 0.4.3 artefact complete upload.

This PR modifies the matrix tasks to not fail fast, and continue on error; this would allow a recovery from the 0.4.3 test release.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@freakboy3742 freakboy3742 requested a review from mhsmith May 6, 2024 07:08
@mhsmith
Copy link
Member

mhsmith commented May 7, 2024

The documentation of these settings is a little unclear, but I don't think we want continue-on-error here. That would cause the workflow to always be considered a success regardless of what happens, so if something goes wrong we might not find out for several days.

To ensure we run all jobs in the matrix even if one of them fails, I think fail-fast is sufficient.

Examples:

@mhsmith mhsmith merged commit 359589a into beeware:main May 7, 2024
16 of 17 checks passed
@freakboy3742 freakboy3742 deleted the resilient-release branch May 7, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants