Rewrite paragraphs about towncrier.
#2565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changes file coming. |
|
I hope I got it right this time. |
freakboy3742
approved these changes
May 12, 2024
There was a problem hiding this comment.
The CI failures you were seeing were due to pre-commit identifying blank space at the end of lines; if you install pre-commit (see the contribution docs for details), those problems will be picked up automatically.
I've made some additional clarifications; but this was really helpful as a first draft. Thanks for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original text:
changes/directory should look like.towncriers doc to explain fragment types.In my view this made first/drive by PRs more difficult to properly do, so I expanded the text a little so it's more explicit.