Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6 import/require Support #100

Merged
merged 2 commits into from Jan 9, 2017
Merged

ES6 import/require Support #100

merged 2 commits into from Jan 9, 2017

Conversation

brunowego
Copy link
Contributor

馃憤

@begriffs
Copy link
Owner

begriffs commented Jan 9, 2017

Thanks! Is this compatible with pre ES6 code as well?

@brunowego
Copy link
Contributor Author

This works when import in ES6 code:

import angular from 'angular';
import Paginate from  'angular-paginate-anything';

const Root = angular
  .module('app', [
    Paginate
  ])
  .name;

export default Root;

@begriffs begriffs merged commit 3e09f13 into begriffs:master Jan 9, 2017
@begriffs
Copy link
Owner

begriffs commented Jan 9, 2017

Do I need to release a new version so that you can pick up the changes?

@brunowego brunowego deleted the patch-1 branch January 9, 2017 14:51
@brunowego
Copy link
Contributor Author

Yes, but let me try some tests first.

@brunowego
Copy link
Contributor Author

I made a mistake, there is an important question about its implementation. If the user only imports the library, it will somehow need to load the template as well.

If the user is using webpack, they can include the html as a template.

Or, we can include paginate-anything-tpls.js instead.

@brunowego
Copy link
Contributor Author

Works nicer now #101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants