Feat/single page #30
Merged
Feat/single page #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 2, 2021 09:28
…y to better represent data.
ans-4175
approved these changes
Nov 3, 2021
| "html-webpack-plugin": "^4.5.2", | ||
| "mini-css-extract-plugin": "^0.9.0", | ||
| "razzle": "^4.0.6", | ||
| "razzle-dev-utils": "^4.0.6", | ||
| "razzle": "^4.2.6", |
| @@ -17,6 +17,7 @@ const App = () => { | |||
| <Switch> | |||
| <Route exact path="/" component={Home} /> | |||
| <Route exact path="/about" component={About} /> | |||
| @@ -33,10 +33,12 @@ | |||
| } | |||
|
|
|||
| h1 { | |||
| font-family: 'TinderFont', cursive; | |||
| font-family: 'TinderFont', "Noto Sans", 'Trebuchet MS', sans-serif; | |||
| border: 1px solid var(--light-grey-tw); | ||
| } | ||
|
|
||
| .button.tweet:hover { |
| @@ -17,6 +17,7 @@ const App = () => { | |||
| <Switch> | |||
| <Route exact path="/" component={Home} /> | |||
| <Route exact path="/about" component={About} /> | |||
| <Route exact path="/:profileId" component={Home} /> | |||
There was a problem hiding this comment.
weh baru sadar disatuin yap
| @@ -13,7 +13,7 @@ function pickRandom(arr, n) { | |||
| result[n] = arr[x in taken ? taken[x] : x]; | |||
| taken[x] = --len in taken ? taken[len] : len; | |||
| } | |||
| return result.map( res => ({...res, id: short.generate() })); | |||
| return result.map( res => ({...res, unique_key: short.generate() })); | |||
| <h2 className='infoText'> | ||
| {lastDirection ? `` : 'Geser gambar untuk memulai'} | ||
| </h2> | ||
| { !lastDirection && <h2 className='infoText'>Geser gambar untuk memulai</h2>} |
|
|
||
| const allGirls = data && ('pages' in data) ? data.pages.flat() : []; | ||
| const allGirls = data && ('pages' in data) |
There was a problem hiding this comment.
urang ga ngerti baca ini, jadi kalau ada profile, si profile ditaruh paling atas kan? tapi di belakangnya tetap dari infiniteQuery kan?
| const allGirls = data && ('pages' in data) ? data.pages.flat() : []; | ||
| const allGirls = data && ('pages' in data) | ||
| ? profile | ||
| ? [...data.pages.flat(), profile] |
| const swiped = (direction, id) => { | ||
| const girl = allGirls.find((item) => item.id === id); | ||
| const swiped = (direction, key) => { | ||
| const girl = allGirls.find((item) => item.unique_key === key); |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Banyak improvement polishing akhir2, termasuk:
Will close #26 and hopefully #10 (simpler approach, less dependency)