Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newrelic: remove go-cache after compile, Github CI compatible + working #186

Merged
merged 7 commits into from
Dec 22, 2021

Conversation

bryanlatten
Copy link
Contributor

@bryanlatten bryanlatten commented Dec 18, 2021

  • On ARM64 variants, cleans go cache after compilation, saving 37MB
  • Collapses variant-specific runtime tests together
  • Adds new (basic) Newrelic startup tests
  • Full implements GH Actions for CI, doesn't replace Travis CI yet, but is ready

@bryanlatten bryanlatten changed the title Newrelic: remove go-cache after compile Newrelic: remove go-cache after compile, Github CI compatible + working Dec 20, 2021
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@bryanlatten bryanlatten force-pushed the newrelic-go-cache branch 4 times, most recently from 49e1379 to 6218ad0 Compare December 20, 2021 18:58
- Cleaning up testing structure
Copy link
Collaborator

@adobejmong adobejmong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Had a few questions but looks pretty good to ship

test.sh Show resolved Hide resolved
scripts/install-newrelic-alpine.sh Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
@adobejmong adobejmong merged commit 6127fa7 into behance:master Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants