Update CSS to pre-split version #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpokryvk
force-pushed
the
fp/css_fixes
branch
2 times, most recently
from
5182727
to
ead45fc
Compare
bittner
reviewed
Jun 30, 2022
behave_html_formatter/behave.css
Outdated
Comment on lines
256
to
257
| h3.failed, | ||
| #behave-header.failed { |
There was a problem hiding this comment.
Suggested change
| h3.failed, | |
| #behave-header.failed { | |
| .failed { |
Can't we simply make this generic? I believe, CSS linters usually complain about over-specification.
There was a problem hiding this comment.
This does not work unfortunately. With important it overwrites all other rules setting background to class failed, without it it has no effect, as it is overridden by rule:
.behave #behave-header, td #behave-header, th #behave-header {
background: #65c400;
...There was a problem hiding this comment.
I copied matched rule, appended .failed (or .undefined) and it seems to work. Not sure, if that is better.
behave_html_formatter/behave.css
Outdated
| h3.failed, #behave-header.failed { | ||
| background: #c20000 !important; | ||
| } | ||
| h3.undefined, #behave-header.undefined { |
There was a problem hiding this comment.
Suggested change
| h3.undefined, #behave-header.undefined { | |
| .undefined { |
Same here. Thou shalt not over-specify.
There were some fixes to CSS sting in html.py that were not reflected to behave.css. Add missing definitions, as without them failed HTML is too green and links are not underlined (thus not visually clickable unless mouse hovered).
bittner
approved these changes
Jun 30, 2022
|
Awesome, thanks! 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some fixes to CSS stirng in html.py that were not reflected to behave.css. Add missing definitions, as without them failed HTML is too green and links are not underlined (thus not visually clickable unless mouse hovered).