make "up" escape sequence work right #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, gnome-terminal, screen, rxvt, ...)
jenisys
added a commit
to jenisys/behave
that referenced
this pull request
Apr 9, 2012
… CursorUp (CUU) escape sequence).
|
I'm using OS X Terminal but this change doesn't seem to break anything. Apologies for it sitting around for so long. |
jeamland
added a commit
that referenced
this pull request
May 9, 2012
make "up" escape sequence work right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See [https://github.com/jeamland/behave/issues/38](issue 38) on main branch. Currently the "up" escape sequence doesn't work right on some terminals (e.g. Gnome Terminal, the standard on Ubuntu; also xterm, a long-time fave). It does work correctly on "screen" and rxvt.
This tiny change (removing a "#" in two places) makes the sequence work right, so the output is as pretty as it is supposed to be. It also seems to work fine on "screen" and rxvt. (I don't know what terminal the devs are using.)