Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error in FixedVersion to_int() #238

Closed
mhosken opened this issue Mar 30, 2016 · 1 comment
Closed

error in FixedVersion to_int() #238

mhosken opened this issue Mar 30, 2016 · 1 comment

Comments

@mhosken
Copy link
Contributor

mhosken commented Mar 30, 2016

I think the key line should be:

inline uint32_t to_int (void) const { return (major << (sizeof(FixedType) * 8)) + minor; }

sizeof() returns bytes and you are shifting by bits. This seems to make a failing test work now.
@behdad
Copy link
Member

behdad commented Apr 4, 2016

Ouch. You are, obviously, right. But I don't get any test changes when I fix that.

@behdad behdad closed this as completed in 6dd80fa Apr 4, 2016
gpgreen pushed a commit to gpgreen/harfbuzz that referenced this issue Jan 10, 2024
@waywardmonkeys
Use freetype-sys rather than Servo's freetype. (harfbuzz#240)
2af84c8 
This simplifies the dependency graph as we weren't getting anything
from using the Servo `freetype` crate here as it also built and
depended upon `freetype-sys`.

Fixes harfbuzz#238.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@behdad @mhosken