Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCP47 lang tag to OT langtag mapping: zh-MO and zh-Hant-HK are mapped to ZHT #300

Closed
jungshik opened this issue Aug 8, 2016 · 6 comments
Assignees

Comments

@jungshik
Copy link

jungshik commented Aug 8, 2016

Test page: http://jungshik.github.io/noto/locltest/locl-test.html

The last three segments in red should all have 'HK' and identical. They're lang-tagged with 'zh-HK', 'zh-Hant-HK' and 'zh-MO'. However, the latter two are mapped to 'ZHT' instead of 'ZHH' ('TW' is shown in place of 'HK' in both Chrome and Firefox).

The heuristics in hb-ot-tag.cc needs a bit of adjustment.

The test font comes from https://github.com/adobe-fonts/locl-test and locl-test.htmll is slightly modified to include zh-Hant-HK and zh-MO.

/cc @kenlunde

@behdad
Copy link
Member

behdad commented Aug 8, 2016

cc @brawer

@jungshik
Copy link
Author

jungshik commented Aug 8, 2016

@kenlunde, do you agree that it's better to map zh-MO (and zh-Hant-Mo) to ZHH instead of ZHT?

@behdad behdad closed this as completed in 10a0d4a Aug 8, 2016
@behdad
Copy link
Member

behdad commented Aug 8, 2016

Fixed 'zh-Hant-HK'; waiting for confirmation from Ken re MO.

@kenlunde
Copy link

kenlunde commented Aug 9, 2016

@jungshik: Yes, the most appropriate mapping for zh-MO (and friends) would be to ZHH rather than ZHT.

behdad added a commit that referenced this issue Aug 9, 2016
behdad added a commit that referenced this issue Aug 9, 2016
@behdad
Copy link
Member

behdad commented Aug 9, 2016

Thanks. All fixed.

@kenlunde
Copy link

kenlunde commented Aug 9, 2016

🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants