Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cast of functions to (hb_destroy_func_t) #474

Closed
behdad opened this issue Apr 19, 2017 · 2 comments
Closed

Remove cast of functions to (hb_destroy_func_t) #474

behdad opened this issue Apr 19, 2017 · 2 comments
Assignees
@behdad
Labels
Chrome Chrome/Chromium project related issues and requests

Comments

@behdad
Copy link
Member

behdad commented Apr 19, 2017

It's undefined to call functions with a different signature. So we need to add wrappers that match hb_destroy_func_t signature and call those.

Originally reported and discussed here:
https://bugs.chromium.org/p/chromium/issues/detail?id=696729
@behdad behdad self-assigned this Apr 19, 2017
@behdad behdad added the Chrome Chrome/Chromium project related issues and requests label Apr 19, 2017
@drott
Copy link
Collaborator

drott commented Apr 20, 2017

Thank you for fixing these.

@drott
Copy link
Collaborator

drott commented Sep 4, 2017

There are two more instances with likely the same root cause in 758478 and 761245, would be great if we could have a fix soon. Thanks very much.

@behdad behdad closed this as completed in e1b6d92 Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@behdad behdad

Labels
Chrome Chrome/Chromium project related issues and requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@behdad @drott