Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect use of shape_plan cache with variation fonts #549

Closed
jfkthame opened this issue Oct 2, 2017 · 3 comments
Closed

Incorrect use of shape_plan cache with variation fonts #549

jfkthame opened this issue Oct 2, 2017 · 3 comments

Comments

@jfkthame
Copy link
Collaborator

jfkthame commented Oct 2, 2017

Currently, hb_shape_plan_create_cached2 doesn't insert a plan in the cache if there were variation coords included in its parameters (see "XXX Fix me" comment in the source).

However, it does still look for an existing plan in the cache (without taking account of variations). This means that if the face has been used with no variation coords, so that a plan has been cached, any future attempt to use it with variations will incorrectly find the existing, no-coord cached plan.
jfkthame added a commit that referenced this issue Oct 2, 2017
@jfkthame
[shape-plan] Don't look for a cached plan if variation coords are spe…
f8b2c76 
…cified. Fixes #549.

This is a temporary hack just to avoid incorrect shaping results, pending proper support
for caching shape-plans with variation coordinates.
@jfkthame jfkthame mentioned this issue Oct 2, 2017
Merged
behdad pushed a commit that referenced this issue Oct 2, 2017
@jfkthame @behdad
[shape-plan] Don't look for a cached plan if variation coords are spe…
19e77e0 
…cified. Fixes #549. (#550)

This is a temporary hack just to avoid incorrect shaping results, pending proper support
for caching shape-plans with variation coordinates.
@behdad
Copy link
Member

behdad commented Oct 2, 2017

Thanks.

Reopening to fix properly by adding hb_ot_layout_table_find_feature_variations() output for GSUB/GPOS to shape-plan cache key.

@behdad behdad reopened this Oct 2, 2017
@khaledhosny
Copy link
Collaborator

@behdad this is fixed now, right?

@behdad
Copy link
Member

behdad commented Nov 19, 2018

Yes. Thanks.

@behdad behdad closed this as completed Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@khaledhosny @behdad @jfkthame