Blacklist GDEF tables of more fonts #266
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is based on bug reports that have been filed against Firefox since it updated to a version of harfbuzz that uses zeroing by GDEF rather than by Unicode. I'm sure there are a bunch more font versions that should also be included; these are just the ones I have on hand and have confirmed as having bad GDEF data. Given how the list here is growing, I think we should reconsider the approach, and perhaps revert to zeroing by Unicode instead.
|
Any idea why the Tibetan doesn't reproduce with IE and other Uniscribe-based systems? Or it does? At this point I think the question is do we want to be forward-looking, or backward. In the past, these bugs went unnoticed on Windows, because windows didn't do shaping for Latin, at least in many situations. The question is: is that still the case wit DirectWrite? I like to align with what DirectWrite is doing moving forward and have a limited blacklisting of past broken fonts, rather than keep diverging from Windows forever. |
I'm away from home at the moment and don't have my Windows systems with me, but I'll try to check next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on bug reports that have been filed against Firefox since it updated to a version of harfbuzz that uses zeroing by GDEF rather than by Unicode. I'm sure there are a bunch more font versions that should also be included; these are just the ones I have on hand and have confirmed as having bad GDEF data.
Given how the list here is growing, I think we should reconsider the approach, and perhaps revert to zeroing by Unicode instead.