Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update NorwegianDateUtil with java8 #68

Closed
wants to merge 1 commit into from
Closed

update NorwegianDateUtil with java8 #68

wants to merge 1 commit into from

Conversation

1goldenboy
Copy link

@1goldenboy 1goldenboy commented Jun 23, 2023 •
edited
Loading

Changes:

  • java8
  • addWorkingDaysToDate allows negative days

@1goldenboy
update NorwegianDateUtil:
4aac04b 
- java8
- make isWorkingDay and isHoliday public
- addWorkingDaysToDate allows negative days
@1goldenboy 1goldenboy mentioned this pull request Jun 23, 2023
Closed
@eivinhb
Copy link
Member

eivinhb commented Jun 23, 2023

Ønsket om å skrive om til java.time står vel høyt på ønskelista. Men det må gjøres over hele linja, ikke stykkevis og delt. Grunnen ser du godt her i PR hvor mye breaking changes det blir.

Så for v1.0 av biblioteket tenker jeg det er naturlig å ta det samlet.

Jeg kan ikke flette denne PR-en slik det står nå.

Tusen takk for bidraget uansett! 👏🙏🏻

@1goldenboy
Copy link
Author

Det var raskt! Helt forståelig :)

@1goldenboy 1goldenboy closed this Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@1goldenboy @eivinhb