Fix bug in key exchange in ENCRYPT and add new feature to change symmetric keys on every view change #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed issue for new key server: -new key is generated when keyserver changes -Added unit test for verifying Added support for changing symmetric key on every view change -configurable through property 'change_keys'
|
I created a JIRA: https://issues.jboss.org/browse/JGRP-1760 |
|
Applied manually with minor changes (e.g. replacing {} with %s in the format string of a log stmt). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the key server does not update key nor the symmetric key version properly when becoming a key server. I added one test case to verify this (testKeyChangesDuringKeyServerChange) and tried to fix the problem as well.
I also added possibility to change the keys on every view change to enable messaging inside a cluster between present members only.
Best regards,
Tero Leppikangas