JGRP-1414 Synchronizing on 'members' MessageDispatcher.cast() is a conte...

[maniksurtani]

...ntion point

See https://issues.jboss.org/browse/JGRP-1414

[Sanne]

Looks good, I've merged it.

[belaban]

Why don't we simply use a CopyOnWriteArrayList ?

[belaban]

I actually found a better solution:

• I made 'members' volatile: this means that reads and writes are separated by memory barriers
• Asssigning can now simply be done: members=new HashSet(new_mbrs);

[maniksurtani]

Better and better. :) Have either of you done any benchmarks with this
change?

On 14 January 2012 16:14, Bela Ban <
reply@reply.github.com

wrote:

I actually found a better solution:

• I made 'members' volatile: this means that reads and writes are
  separated by memory barriers
• Asssigning can now simply be done: members=new
  HashSet(new_mbrs);

---

Reply to this email directly or view it on GitHub:
#23 (comment)

Manik

Sent from my iPad 4 beta 3 with a telekinetic keyboard

[belaban]

Nope, not yet.

[Sanne]

I would like to, but this won't make a difference in my current test scenario as JGroups is far from being the main bottleneck.

Hopefully by tonight it will be, so keep me updated I'd you have a patch (either final our a draft)

[belaban]

If you check out the 3.x branch (JGroups_Branch_3_0), you'll get the change (2e18494).