Jgrp 1388/dns ping documentation #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @slaskawi Looks good. Wouldit make sense though to add 1-2 sentences on when to use DNS_PING and when KUBE_PING, and perhaps a short explanation of the diffs? |
|
Good point! I will add it. Thanks!
…On Fri, Jan 13, 2017 at 10:01 AM, Bela Ban ***@***.***> wrote:
Hi @slaskawi <https://github.com/slaskawi> Looks good. Wouldit make sense
though to add 1-2 sentences on when to use DNS_PING and when KUBE_PING, and
perhaps a short explanation of the diffs?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#338 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AIBvhtlYxSCcdLS6fuLmxne_rbpBc-kpks5rRz1OgaJpZM4Lio4K>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/JGRP-1388
Additional documentation for
DNS_PING.Hey @belaban!
This is the last PR for
DNS_PING. I created a PR (and not pushed directly) because I wanted you to take a look if I didn't miss any spot where we need additional documentation.Cheers!