Add explicit module info #792
Conversation
|
Hmm... compilation with ant and mavcen succeeds, but IntelliJ complains: |
|
This is perhaps not helpful, but IntelliJ is working fine on my machine. Maybe you need to upgrade your IJ? |
|
Still the same problem, I'm on 2023.2.6 |
|
Thats the same version as me. I nuked my local and re-cloned from github and all was fine. Maybe its an issue as to whether its a "maven project" in intellij's eyes? I'm also on a mac if that ends up mattering. (I definitely have incentive to figure out whats going on - partially so you don't revert and partially so I can be aware of this in the future) |
|
I think that this pr must have a few tests executed with the modular path,
otherwise it's hard to validate its correctness.
Tristan
…On Wed, 1 May 2024, 19:10 Ethan McCue, ***@***.***> wrote:
Thats the same version as me.
I nuked my local and re-cloned from github and all was fine. Maybe its an
issue as to whether its a "maven project" in intellij's eyes? I'm also on a
mac if that ends up mattering.
(I definitely have incentive to figure out whats going on - partially so
you don't revert and partially so I can be aware of this in the future)
—
Reply to this email directly, view it on GitHub
<#792 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC72HT7RDVABSPI2WGUMFDZAEOZNAVCNFSM6AAAAABHAPONPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBYG44DGMBRGQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
This is driving me crazy and now I have a new error: Exception in thread "main" java.lang.NoClassDefFoundError: production/JGroups/module-info is not a class because access_flag ACC_MODULE is set. Same issue regardless whether I import the project as maven or from srcs (ant). I'm removing |
Adds an explicit module-info to the final artifact