Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving formatting for edge cases of ForStatement #112

Closed
belav opened this issue Apr 18, 2021 · 0 comments · Fixed by #343
Closed

Improving formatting for edge cases of ForStatement #112

belav opened this issue Apr 18, 2021 · 0 comments · Fixed by #343
Assignees
Labels
area:formatting type:bug Something isn't working
Milestone

Comments

@belav
Copy link
Owner

belav commented Apr 18, 2021

Due to the unit tests ignoring compilation errors in code, for statements were not actually formatting the way we wanted.
These last two cases look bad

        for (
            var laksdflasdjfkaskdlfklasdfkljasdf = 0;
            laksdflasdjfkaskdlfklasdfkljasdf
            < laksdflasdjfkaskdlfklasdfkljasdf + 1;
            laksdflasdjfkaskdlfklasdfkljasdf++
        ) {
            break;
        }

        for (
            var laksdflasdjfkaskdlfklasdfkljasdf = 0,
                lkasdfkjlasjldkfljaskdflkasdfljkasdfljk = 1;
            laksdflasdjfkaskdlfklasdfkljasdf
            < laksdflasdjfkaskdlfklasdfkljasdf + 1;
            laksdflasdjfkaskdlfklasdfkljasdf++,
                lkasdfkjlasjldkfljaskdflkasdfljkasdfljk
        ) {
            break;
        }
@belav belav added type:bug Something isn't working area:formatting labels Apr 18, 2021
@belav belav self-assigned this Jun 27, 2021
@belav belav changed the title ForStatement Formatting. Improving formatting for edge cases of ForStatement Jun 27, 2021
@belav belav added this to the 0.9.8 milestone Jun 27, 2021
belav added a commit that referenced this issue Jun 27, 2021
belav added a commit that referenced this issue Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:formatting type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant