Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet-csharpier process never closes #1231

Closed
mejobloggs-cw opened this issue Apr 18, 2024 · 2 comments · Fixed by #1234
Closed

dotnet-csharpier process never closes #1231

mejobloggs-cw opened this issue Apr 18, 2024 · 2 comments · Fixed by #1234

Comments

@mejobloggs-cw
Copy link

Is this a bug, or intended behaviour?

If I open Visual Studio, and a C# file, then close Visual Studio, I notice dotnet-csharpier is still running in Task Manager

If I repeat this 10x, I will have no Visual Studio open, but 10x dotnet-csharpier.exe in Task Manager.

VS 2022 Preview 4.0
VS CSharpier Extension 1.5.2
Csharpier: 0.28.1

@belav
Copy link
Owner

belav commented Apr 19, 2024

This wasn't intended, I have code that I assumed was killing off the running csharpier process when VS was closed, but it doesn't appear to be working. I'll hopefully have a fix for it soon.

@belav belav added this to the Planned - Extensions milestone Apr 19, 2024
@belav
Copy link
Owner

belav commented Apr 19, 2024

Do you have "Use CSharpier Server" turned on? I was only able to reproduce it while that was on. The option was intended for testing a new way of communicating with CSharpier, and there was a bug there with not actually killing dotnet-csharpier if that option was on.

With that option off, it kills off dotnet-csharpier as expected.

I'll get this fix out shortly + make the csharpier server feature official when using 0.28+

belav added a commit that referenced this issue Apr 19, 2024
belav added a commit that referenced this issue Apr 19, 2024
belav added a commit that referenced this issue Apr 19, 2024
belav added a commit that referenced this issue Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants